-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GitAuto to open pull requests from Jira tickets #391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hiroshinishio - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🧪 Benchify Analysis of PR
|
File | Example Input | # Inputs Found | Description | |
---|---|---|---|---|
✅ | services/github/github_types.py | login='QTr00', id=0, node_id='', avatar_url='', gravatar_id='', url='', html_url='', followers_url='', following_url='', gists_url='', starred_url='', subscriptions_url='', organizations_url='', repos_url='', events_url='', received_events_url='', type='', user_view_type='', site_admin=False |
199 | Creating an instance of the Owner dataclass with valid data should result in an object with the same attributes as the input data. |
Reproducible Unit Tests
import jsonpickle
import unittest
import time
import asyncio
from services.github.github_types import *
# Property: Creating an instance of the Owner dataclass with valid data should result in an object with the same attributes as the input data.
def benchify_test_owner_dataclass(login, id, node_id, avatar_url, gravatar_id, url, html_url, followers_url, following_url, gists_url, starred_url, subscriptions_url, organizations_url, repos_url, events_url, received_events_url, type, user_view_type, site_admin):
owner = Owner(login, id, node_id, avatar_url, gravatar_id, url, html_url, followers_url, following_url, gists_url, starred_url, subscriptions_url, organizations_url, repos_url, events_url, received_events_url, type, user_view_type, site_admin)
assert owner.login == login
assert owner.id == id
assert owner.node_id == node_id
assert owner.avatar_url == avatar_url
assert owner.gravatar_id == gravatar_id
assert owner.url == url
assert owner.html_url == html_url
assert owner.followers_url == followers_url
assert owner.following_url == following_url
assert owner.gists_url == gists_url
assert owner.starred_url == starred_url
assert owner.subscriptions_url == subscriptions_url
assert owner.organizations_url == organizations_url
assert owner.repos_url == repos_url
assert owner.events_url == events_url
assert owner.received_events_url == received_events_url
assert owner.type == type
assert owner.user_view_type == user_view_type
assert owner.site_admin == site_admin
# The next batch of tests are passing.
def test_owner_dataclass_passing_0():
login=''
id=0
node_id=''
avatar_url=''
gravatar_id=''
url=''
html_url=''
followers_url=''
following_url=''
gists_url=''
starred_url=''
subscriptions_url=''
organizations_url=''
repos_url=''
events_url=''
received_events_url=''
type=''
user_view_type=''
site_admin=False
benchify_test_owner_dataclass(login, id, node_id, avatar_url, gravatar_id, url, html_url, followers_url, following_url, gists_url, starred_url, subscriptions_url, organizations_url, repos_url, events_url, received_events_url, type, user_view_type, site_admin)
def test_owner_dataclass_passing_1():
login='r'
id=0
node_id=''
avatar_url=''
gravatar_id=''
url=''
html_url=''
followers_url=''
following_url=''
gists_url=''
starred_url=''
subscriptions_url=''
organizations_url=''
repos_url=''
events_url=''
received_events_url=''
type=''
user_view_type=''
site_admin=False
benchify_test_owner_dataclass(login, id, node_id, avatar_url, gravatar_id, url, html_url, followers_url, following_url, gists_url, starred_url, subscriptions_url, organizations_url, repos_url, events_url, received_events_url, type, user_view_type, site_admin)
def test_owner_dataclass_passing_2():
login='wu1'
id=0
node_id=''
avatar_url=''
gravatar_id=''
url=''
html_url=''
followers_url=''
following_url=''
gists_url=''
starred_url=''
subscriptions_url=''
organizations_url=''
repos_url=''
events_url=''
received_events_url=''
type=''
user_view_type=''
site_admin=False
benchify_test_owner_dataclass(login, id, node_id, avatar_url, gravatar_id, url, html_url, followers_url, following_url, gists_url, starred_url, subscriptions_url, organizations_url, repos_url, events_url, received_events_url, type, user_view_type, site_admin)
# Found 196 more passing tests.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
No description provided.