Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a log to investigate an error: Could not get the default branch in add_issue_templates() #385

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

hiroshinishio
Copy link
Collaborator

No description provided.

@hiroshinishio hiroshinishio merged commit ca3ddc9 into main Nov 21, 2024
2 checks passed
@hiroshinishio hiroshinishio deleted the wes branch November 21, 2024 01:32
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hiroshinishio - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider keeping this as INFO level since this is a retryable operation. ERROR logs should typically be reserved for unrecoverable situations. If you need to debug specific issues, consider adding metrics for retry attempts or more detailed contextual information in the log message instead.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant