Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unnecessary logs in file_manager.py #338

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Move unnecessary logs in file_manager.py #338

merged 1 commit into from
Oct 24, 2024

Conversation

hiroshinishio
Copy link
Collaborator

@hiroshinishio hiroshinishio commented Oct 24, 2024

Summary by Sourcery

Enhancements:

  • Relocate encoding log statements to the error handling section in file_manager.py.

Copy link

sourcery-ai bot commented Oct 24, 2024

Reviewer's Guide by Sourcery

The changes relocate encoding debug logs in the file_manager.py from the beginning of the apply_patch function to the error handling section, where they are more relevant for debugging purposes.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Moved debug logging of text encodings from function start to error handling section
  • Removed encoding debug prints from the beginning of the function
  • Added encoding debug prints in the error handling block
  • Slightly shortened the encoding log messages for better readability
utils/file_manager.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@hiroshinishio hiroshinishio merged commit c40f6de into main Oct 24, 2024
2 checks passed
@hiroshinishio hiroshinishio deleted the wes branch October 24, 2024 00:14
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hiroshinishio - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant