-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 178 healy: Upsert user email to database #336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… do it for create_user_request
i want to push a branch with the least diffs from main as possible
…allation and create_user_request, added on_conflict to create_user, and created variables for user_name and unique_issue_id in test_complete_and_update_usage_record_only_updates_one_record
hiroshinishio
changed the title
Issue 178 healy
Issue 178 healy: Upsert user email to database
Oct 24, 2024
hiroshinishio
requested changes
Oct 27, 2024
hiroshinishio
requested changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also update the branch too!
hiroshinishio
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes API request to github API based on username to get email. If email is received, it upserts to users table on installation and updates on create_user_request
PR checklist
Test Cases
Here is the list of test cases:
Evidence
Here is the list of Loom video URL(s):
Environment Variables Setting
Here is the list of configurations and screenshots where we have changes other than code:
Summary by Sourcery
Fetch user email from GitHub API and update the users table in the database during installation and user request creation. Add tests to ensure correct email handling.
New Features:
Enhancements:
Tests: