Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve an error handling to debug this error: update_comment encountered an MissingSchema: Invalid URL 'None': No scheme supplied. #199

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Improve an error handling to debug this error: update_comment encountered an MissingSchema: Invalid URL 'None': No scheme supplied. #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/gitauto_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ async def handle_gitauto(payload: GitHubLabeledPayload, trigger_type: str) -> No
token=token,
)

comment_url = create_comment(
comment_url: str = create_comment(
owner=owner,
repo=repo_name,
issue_number=issue_number,
Expand Down
2 changes: 1 addition & 1 deletion services/github/github_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def commit_changes_to_remote_branch(
put_response.raise_for_status()


@handle_exceptions(default_return_value=None, raise_on_error=False)
@handle_exceptions(raise_on_error=True)
def create_comment(
owner: str, repo: str, issue_number: int, body: str, token: str
) -> str:
Expand Down