Add RemoveIf and RetainAll methods to collections #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Su <ghosind@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 86.67% 82.68% -4.00%
==========================================
Files 15 15
Lines 1096 1149 +53
==========================================
Hits 950 950
- Misses 107 160 +53
Partials 39 39 ☔ View full report in Codecov by Sentry. |
| @@ -154,6 +154,16 @@ func (set *ConcurrentHashSet[T]) RemoveAll(c ...T) bool { | |||
| return isChanged | |||
| } | |||
|
|
|||
| // RemoveIf removes all of the elements of this set that satisfy the given predicate. | |||
| func (set *ConcurrentHashSet[T]) RemoveIf(filter func(T) bool) bool { | |||
| panic("not implemented") | |||
There was a problem hiding this comment.
The method RemoveIf is not implemented and will cause a runtime panic. Please implement this method.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
|
||
| // RetainAll retains only the elements in this set that are contained in the specified collection. | ||
| func (set *ConcurrentHashSet[T]) RetainAll(c ...T) bool { | ||
| panic("not implemented") |
There was a problem hiding this comment.
The method RetainAll is not implemented and will cause a runtime panic. Please implement this method.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4