Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(publish): Remove status provider setting from Craft config #8762

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 9, 2023

So, as explained in getsentry/craft#482 (comment) (+ the following messages), I believe that in addition to the default behaviour of Craft's GH status provider, also the contexts feature is broken. It seems like the GitHub API endpoint we use to get the combined statuses of a commit doesn't return statuses (where the contexts would be included) anymore and it always returns state pending (which seems to be a known issue).

Considering that there is an annoying but proven workaround to this issue (namely to wait ~30min with accepting the publish run until CI has passed), I'm not going to waste more time with trying to fix this.

This PR removes the status provider config which will make craft fall back to the (broken) default behaviour.

(once this is merged to develop we need to merge develop into master and cut the release)

@Lms24 Lms24 requested review from mydea and lforst August 9, 2023 08:58
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 74.96 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.11 KB (0%)
@sentry/browser - Webpack (gzipped) 21.81 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.58 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.15 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 219.29 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.67 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.83 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.02 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.16 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped) 21.84 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 92.78 KB (+0.15% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.64 KB (+0.06% 🔺)

@Lms24 Lms24 merged commit 51159b7 into develop Aug 9, 2023
@Lms24 Lms24 deleted the lms/ref-remove-statusprovider branch August 9, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants