chore(publish): Remove status provider setting from Craft config #8762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, as explained in getsentry/craft#482 (comment) (+ the following messages), I believe that in addition to the default behaviour of Craft's GH status provider, also the
contexts
feature is broken. It seems like the GitHub API endpoint we use to get the combined statuses of a commit doesn't return statuses (where the contexts would be included) anymore and it always returns statepending
(which seems to be a known issue).Considering that there is an annoying but proven workaround to this issue (namely to wait ~30min with accepting the publish run until CI has passed), I'm not going to waste more time with trying to fix this.
This PR removes the status provider config which will make craft fall back to the (broken) default behaviour.
(once this is merged to
develop
we need to merge develop into master and cut the release)