🤖 Enhanced Error Handling and Stacktrace Validation #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry-autofix[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi there! This PR was automatically generated by Autofix 🤖
This fix was triggered by admin@sentry.io
This pull request introduces improved error handling and input validation for JSON requests and stacktraces. In json_api.py, it replaces the previous method of raising a BadRequest error with a more detailed ApiErrorResponse for invalid JSON formats and validation errors, providing specific error codes and messages. Additionally, it collects validation details to give clearer feedback on which fields failed validation. In grouping.py, a new static method preprocess_stacktrace is added to clean and validate stacktrace input, which ensures it is a non-empty string and meets minimum length requirements. The error messages have been updated for clarity on required fields.
If you have any questions or feedback for the Sentry team about this fix, please email autofix@sentry.io with the Run ID: 1.