Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Enhancements in Stacktrace Handling and API Error Management #1713

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sentry-autofix[bot]
Copy link
Contributor

@sentry-autofix sentry-autofix bot commented Jan 9, 2025

👋 Hi there! This PR was automatically generated by Autofix 🤖

This fix was triggered by admin@sentry.io

This pull request introduces significant improvements to the handling of stacktraces in the grouping logic and enhances error management in the API. Key changes include:

  1. Stacktrace Validation: A new validation process for stacktraces has been added. The check_field_is_not_empty method now throws a more detailed error if the stacktrace is empty, and checks for a minimum length to ensure valid input.

  2. Stacktrace Normalization: A new static method preprocess_stacktrace normalizes whitespace in stacktrace strings for consistency and removes the risk of peaks due to inconsistent formatting.

  3. Error Handling in Encoding Methods: Updated methods for encoding stacktraces to raise appropriate errors if input is empty, and to preprocess them before encoding.

  4. Custom API Error Responses: Introduced a new APIValidationError class to handle validation errors more gracefully, providing structured error responses with detailed information on validation issues in JSON format.

  5. Detailed Validation Feedback: The error handling mechanism now extracts field-specific validation errors from Pydantic’s ValidationError to provide clearer feedback to clients on what went wrong in their API requests.

Overall, these changes enhance the robustness of the stacktrace management and improve the client experience by providing clearer, structured error messages.

If you have any questions or feedback for the Sentry team about this fix, please email autofix@sentry.io with the Run ID: 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants