Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9568 fixed selection with Alt + Mouse #9640

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix #9568 fixed selection with Alt + Mouse #9640

merged 1 commit into from
Oct 23, 2023

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Oct 20, 2023

Description

the event name object has changed over time in ol lib

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

Fix #9568

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch Regression C027-COMUNE_FI-2023-SUPPORT labels Oct 20, 2023
@MV88 MV88 added this to the 2023.02.01 milestone Oct 20, 2023
@MV88 MV88 requested a review from tdipisa October 20, 2023 16:30
@MV88 MV88 self-assigned this Oct 20, 2023
@tdipisa tdipisa requested review from offtherailz and removed request for tdipisa October 23, 2023 07:49
offtherailz
offtherailz approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, it works. Thank you for the update.

@offtherailz offtherailz merged commit 334cd95 into geosolutions-it:master Oct 23, 2023
4 checks passed
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on DEV ? Thank you/

@ElenaGallo
Copy link
Contributor

Test passed, @MV88 please backport. Thanks

MV88 added a commit to MV88/MapStore2 that referenced this pull request Oct 23, 2023
@MV88
Fix geosolutions-it#9568 fixed selection with Alt + Mouse (geosolutio…
2972883 
…ns-it#9640)
@MV88 MV88 mentioned this pull request Oct 23, 2023
Merged
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 23, 2023
tdipisa pushed a commit that referenced this pull request Oct 23, 2023
@MV88
Fix #9568 fixed selection with Alt + Mouse (#9640) (#9645)
e9d8bd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@MV88 MV88

Labels
bug C027-COMUNE_FI-2023-SUPPORT Regression
Projects
None yet
Milestone
2023.02.01
Development

Successfully merging this pull request may close these issues.

Selection of features with Alt + Mouse in the attribute table does not work
4 participants
@MV88 @offtherailz @ElenaGallo @tdipisa