Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9620 better error handling of GeoProcessing #9621

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Oct 18, 2023

Description

Error described in the issue now provides a feedback and the app does not crash with specific use case

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

Fix #9620
Fix #9603

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C265-ATOLCD-2023-DEV_MS_CNR labels Oct 18, 2023
@MV88 MV88 added this to the 2023.02.01 milestone Oct 18, 2023
@MV88 MV88 requested a review from offtherailz October 18, 2023 10:25
@MV88 MV88 self-assigned this Oct 18, 2023
@offtherailz
Copy link
Member

For sure this exception is not handled.
We have a lot of layers and use cases where things do not work. Use them to test.
screencast-bpconcjcammlapcogcnnelfmaeghhagj-2023.10.18-13_06_22.webm

I'm going to review this better when you think that all the exceptions are correctly handled

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It improved a lot. It works well for me.
Please change the text about the source layer, because a source layer as line is anyway accepted.

Question:
I tried an intersection between raoads and streams, I have no results (theoretically I should have some points)
I tried an intersection between roads and roads, it worked.

I think this is a bug/missing feature of the process.

@offtherailz offtherailz merged commit 937edb2 into geosolutions-it:master Oct 19, 2023
4 checks passed
MV88 added a commit to MV88/MapStore2 that referenced this pull request Oct 19, 2023
@ElenaGallo
Copy link
Contributor

Test passed @MV88 please backport to the stable branch. Thanks

@MV88
Copy link
Contributor Author

MV88 commented Oct 19, 2023

backport here #9630

@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants