#9464: fix issue of not showing background layer in case of switching from 2D mode to 3D mode #9614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se of switching from 2D mode to 3D mode
mahmoudadel54
added
bug
investigation
3D
1 task
MV88
requested changes
Oct 17, 2023
There was a problem hiding this comment.
can you add a chapter in the migration guidelines that tells people to edit these two files?
add it in between these two
## Migration from 2023.02.xx to 2024.01.00
### Adding spatial filter to dashboard widgets
something like:
### Fixing background config
From this version in order to fix default 3d background config a change is needed here
- `localConfig.json` by adding **visibility: false** to the Empty Background entry in intialState.defaultState.catqalog.default.staticServices.default_map_backgrounds.backgrounds
- `new.json` by adding **visibility: false** to the Empty Background entry
see this PR [9614](https://github.com/geosolutions-it/MapStore2/pull/9614/files) for more details
…ackground for old maps
tdipisa
requested changes
Oct 18, 2023
description: remove issue reference from migration doc
…D mode for the old maps
MV88
reviewed
Oct 19, 2023
MV88
requested changes
Oct 19, 2023
There was a problem hiding this comment.
@mahmoudadel54 seems ok but can you ping @allyoucanmap to have a confirmation on the comment below?
MV88
approved these changes
Oct 20, 2023
MV88
approved these changes
Oct 23, 2023
|
@ElenaGallo please test it in DEV |
tdipisa
added
the
BackportNeeded
|
Test passed, @mahmoudadel54 please backport to the stable branch. Thanks |
backport is done ===> #9636 |
mahmoudadel54
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing not showing the default background layer on the map when user switches from 2D mode to 3D mode.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9464
What is the current behavior?
#9464
What is the new behavior?
When a user switches from 2d mode map to 3D mode, the default background layer will be shown.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)