Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10753: Improve the way group names are visualized in user settings by showing tooltip for selected items #10757

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mahmoudadel54
Copy link
Contributor

Description

This PR improves the way that group names are visualized in user settings modal by showing a tooltip for the selected items to cover the truncated long names with ellipsis.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: enhancement

Issue

#10753

What is the current behavior?
#10753

What is the new behavior?

demoUserSettings.mp4

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

…user settings by showing tooltip for selected items
@mahmoudadel54 mahmoudadel54 added this to the 2025.01.00 milestone Jan 15, 2025
@mahmoudadel54 mahmoudadel54 requested a review from MV88 January 15, 2025 14:54
@mahmoudadel54 mahmoudadel54 self-assigned this Jan 15, 2025
@mahmoudadel54 mahmoudadel54 linked an issue Jan 15, 2025 that may be closed by this pull request
6 tasks
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove this comment?
// const Message = require('../I18N/Message').default;

web/client/components/manager/users/UserGroups.jsx Outdated Show resolved Hide resolved
…user settings by showing tooltip for selected items (resolve review comments)

- remove unused comment for import + edit a typo mistake in a comment in UserGroups.jsx
@mahmoudadel54 mahmoudadel54 requested a review from MV88 January 17, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the way group names are visualized in user settings
2 participants