10294 fix arcgis layer grouping bug

[Igi-ID]

Description

This PR fixes #10294 , namely, adding an arcgis type layer to a selected group does not add the layer to the group.

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

• Bugfix

Issue

What is the current behavior?
#10294

What is the new behavior?
Layer is correctly added to the selected group on initialization,

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

• Yes, and I documented them in migration notes
• No

Other useful information

[tdipisa]

@Igi-ID (FYI @allyoucanmap) I think the PR title is confusing since there is no specific mention of arcgis in the connected issue. If the problem is effectively connected to layers coming from an arcgis server it is better to specify that in the issue also indicating some URL samples to use for testing purposes.

[Igi-ID]

@Igi-ID (FYI @allyoucanmap) I think the PR title is confusing since there is no specific mention of arcgis in the connected issue. If the problem is effectively connected to layers coming from an arcgis server it is better to specify that in the issue also indicating some URL samples to use for testing purposes.

I've adjusted the linked issue to better reflect the nature of the bug. To clarify here as well, the bug only occurs when constructing the layer object inside MS and only for the arcgis type. When the layer object is created, a group property should exist on the layer for grouping inside TOC to work.

[tdipisa]

@Igi-ID thank you. I've changed the milestone accordingly then.

[allyoucanmap]

@ElenaGallo please test this fix on dev, thanks