Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API / Improve OpenAPI spec schema. #8602

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

API / Improve OpenAPI spec schema. #8602

wants to merge 1 commit into from

Conversation

fxprunayre
Copy link
Member

  • /site response is using SettingsListToObjectSerializer which returns a simple object

image

  • /records/{metadataUuid}/processes/{process} can receive additional parameters forwarded to process. This will also improve OpenAPI generator outputs.

image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@fxprunayre
API / Improve OpenAPI spec schema.
d63cc9e 
* /site response is using SettingsListToObjectSerializer which returns a simple object
* OpenAPI generator does not generate parameters for process API.
@fxprunayre fxprunayre requested a review from josegar74 January 14, 2025 14:46
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@josegar74 josegar74 added this to the 4.4.7 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josegar74 josegar74 Awaiting requested review from josegar74

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.7
Development

Successfully merging this pull request may close these issues.
2 participants
@fxprunayre @josegar74