Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-1343: add "more info" link in problem report form #1198

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ltkum
Copy link
Contributor

@ltkum ltkum commented Jan 14, 2025

Issue: We want the users to understand what each category is used for in the feedback form.

Fix: We add a link under the category selection that leads to the news about the categories. In the near future, we'll change the link to the help page itself.

Test link

@ltkum ltkum requested review from ismailsunni and pakb January 14, 2025 16:11
@ltkum
Copy link
Contributor Author

ltkum commented Jan 14, 2025

@Luke252 wanted to add this in the next deploy, so if everything is all right, feel free to merge it yourselves.

Copy link

cypress bot commented Jan 14, 2025

web-mapviewer    Run #4298

Run Properties:  status check passed Passed #4298  •  git commit be734f032e: Merge pull request #1198 from geoadmin/feat-PB-1343-add-more-info-link-for-categ...
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #4298
Run duration 01m 43s
Commit git commit be734f032e: Merge pull request #1198 from geoadmin/feat-PB-1343-add-more-info-link-for-categ...
Committer Martin Künzi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

@ltkum ltkum force-pushed the feat-PB-1343-add-more-info-link-for-categories branch from b6e12bd to 3d5e601 Compare January 14, 2025 16:38
Copy link
Contributor

@ismailsunni ismailsunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ltkum ltkum force-pushed the feat-PB-1343-add-more-info-link-for-categories branch from 3d5e601 to 2c553bf Compare January 16, 2025 09:26
Issue: We want the users to understand what each category is used for in the feedback form.

Fix: We add a link under the category selection that leads to the news about the categories. In the near future, we'll change the link to the help page itself.
@ltkum ltkum force-pushed the feat-PB-1343-add-more-info-link-for-categories branch from 2c553bf to 4df316c Compare January 16, 2025 09:38
@ltkum ltkum force-pushed the feat-PB-1343-add-more-info-link-for-categories branch from 4df316c to c8814c5 Compare January 16, 2025 10:25
@ltkum ltkum merged commit be734f0 into develop Jan 16, 2025
6 checks passed
@ltkum ltkum deleted the feat-PB-1343-add-more-info-link-for-categories branch January 16, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants