PB-1327: Refactored 'DropdownItem' to translate the button title internally #1191
+362
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 47s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
pakb
force-pushed
the
bug_PB-1327-categories-translation-issue
branch
from
9b9729e to
86e6336
Compare
sami-nouidri-swisstopo
force-pushed
the
bug_PB-1327-categories-translation-issue
branch
from
022e513 to
272e962
Compare
…rnally. This involves translating the title in the getter, such that when called, it is up-to-date with the current language context in web-mapviewer.
instead of failing and raising an error while using t(...), vue-i18n now gives back the "key" or text it received unchanged. This way we can call translation tool on input from other component without worrying on raising errors. The DropdownButton now translates anything it receives, making it possible to give it either keys, or translated text directly. Removing the class DropdownItem and replacing it with a typedef instead. We now know that passing classes with get/set to Vuex is a bad practice, and we should avoid it.
Adapted the cypress tests to the new drop down item values.
so that it uses aliases on element whenever possible, and also test the payload of feedback for the category too.
pakb
force-pushed
the
bug_PB-1327-categories-translation-issue
branch
from
d1d19cd to
d97dae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves translating the title in the getter, such that when called, it is up-to-date with the current language context in web-mapviewer.
Test link