Update vignette and analysis #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of computational reasons some cells of the vignettes are not rerun each time. They rely on intermediately stored files. While this is error-prone, it had been chosen as a computationally pragmatic way. Here, we update the results and streamline the generation of the result files. The aim is to make more evident where each result was generated and is used. Lastly the sensitivity vignette has been changed to calibration of kphio, kphio_par_b, and kc_jmax; instead of kphio, kc_jmax, and soilm_betao.
- Remove sitename from biomee drivers' site_info as it was clashing with the top level key (when unnesting) - Use parallel execution to calibrate models (not necessary faster but at least it prints out the progress) - Update analysis to calibrate new parameter set for morris analysis.
- Bump version to 5.0.0
fabern
reviewed
Nov 26, 2024
…te-vignette-files
|
@stineb, @marcadella According to semver, breaking API changes would require a Note that currently both |
|
I've discussed this with @marcadella . Yes, it should be 5.0.0. |
fabern
reviewed
Nov 26, 2024
|
Alright, I think we are finally ready. Once this PR is merged in Master, I'll submit to CRAN. |
fabern
reviewed
Nov 26, 2024
fabern
previously approved these changes
Nov 26, 2024
fabern
reviewed
Nov 26, 2024
fabern
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.