Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional closing modal methods #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laurenceberry
Copy link

Adds the option to close the modal using the browser back button and by clicking off the modal itself.

@gdkraus
Copy link
Owner

gdkraus commented Feb 12, 2015

Thanks. I'll take a look at the browser history code. As for the clicking on the overlay, is that the expected behavior when clicking on it - that it should close? I'm not sure and I haven't seen that discussed anywhere.

@lectrotext
Copy link

So the difference is non modal vs modal.
A modal element does not allow focus to be lost (ie - clicking off the modal). A modal can only be dismissed by submitting or canceling.
A non modal allows the window to be dismissed when focus is lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants