This repository has been archived by the owner on Feb 16, 2021. It is now read-only.
Type override for enums #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadam313
commented
Dec 29, 2017
| return formats[s.format]; | ||
| } | ||
|
|
||
| formatPredicate = formats[s.format]; |
There was a problem hiding this comment.
doing this to preserve the order of the "and" conditions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to override enum types by moving the "format type check" to the first thing in the string handler. I think it's reasonable to allow consumers to override enum types as well.
Also a comment to explain the format override system only works for strings.