Made request thread safe #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gavv your thoughts? |
Signed-off-by: ROHITH RAJU <rohithraju488@gmail.com>
Rohith-Raju
force-pushed
the
requestThreadSafety
branch
from
10f4df6 to
402b6af
Compare
|
Hey, thanks for PR, but seems you ignored the text from the issue? I mean the part about matchers and teansformers, which is essential part of it. Look, I'm always happy to give an advice or help, but put yourself in my place. If I have to provide line-by-line guide each time, it's just unproductive, writing that code by myself would be faster. |
Yes, I'm sorry. I totally ignored this. Won't happen again. |
|
Deleted this as the changes are irrelevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread safety for request struct
Signed-off-by:_ ROHITH RAJU rohithraju488@gmail.com