Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: drop unused codepath #125

Closed
wants to merge 1 commit into from
Closed

cleanup: drop unused codepath #125

wants to merge 1 commit into from

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Jan 8, 2025

.ci/component_descriptor was copied into this repository from https://github.com/gardener/gardener.

Historically, the file used to be vendored into muliple repositories and thus needed to support
different repository-layouts. This is no longer the case, as vendoring was dropped some time back.

Rm unused codepath as cleanup (will help migrating from Concourse-Pipeline-Template).

How to categorize this PR?
/area delivery
/kind cleanup

Release note:

drop unused codepath from component_descriptor creation script.

@ccwienk
cleanup: drop unused codepath
4745002 
There is only one remaining repository (considering default branches
only) in github.com/gardener organisation that features a file
`_images.tpl`:
  https://github.com/gardener/gardener-extension-provider-aws

However, said repository no longer seems to vendor gardener/gardener's
copy of component_descriptor script. Rm unused codepath as cleanup (will
help migrating from Concourse-Pipeline-Template).
@ccwienk ccwienk requested a review from a team as a code owner January 8, 2025 19:37
@gardener-robot gardener-robot added area/delivery Delivery related kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 8, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 8, 2025
@ccwienk ccwienk closed this Jan 8, 2025
@ccwienk ccwienk deleted the cleanup-component-descriptor-script branch January 8, 2025 21:31
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/delivery Delivery related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccwienk @gardener-robot-ci-1 @gardener-robot