Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to inject EFFECTIVE_VERSION build-arg #190

Merged

Conversation

oliver-goetz
Copy link
Member

/kind bug

What this PR does / why we need it:
Add option to inject EFFECTIVE_VERSION build-arg that gardener/gardener binaries contain the right version info.

Manual test for a PR presubmit job:
https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/5779/pull-gardener-publish-test-images/1513833918111944704

~ docker run --rm eu.gcr.io/gardener-project/gardener/apiserver:v1.45.0-dev-4f5dd702ed31a14abc026d3bce8381cbddbe97ed --version                                                                                                                (gardener-prow-trusted/default)
Unable to find image 'eu.gcr.io/gardener-project/gardener/apiserver:v1.45.0-dev-4f5dd702ed31a14abc026d3bce8381cbddbe97ed' locally
v1.45.0-dev-4f5dd702ed31a14abc026d3bce8381cbddbe97ed: Pulling from gardener-project/gardener/apiserver
5758d4e389a3: Already exists
317fe4fc145e: Pull complete
a92bd55327e9: Pull complete
Digest: sha256:d402045447d0aad07b9bab49f30e02099cd34242d59cdb54f00c0aae5f38799f
Status: Downloaded newer image for eu.gcr.io/gardener-project/gardener/apiserver:v1.45.0-dev-4f5dd702ed31a14abc026d3bce8381cbddbe97ed
Gardener v1.45.0-dev-4f5dd702ed31a14abc026d3bce8381cbddbe97ed

Manual test for a postsubmit job:
https://prow.gardener.cloud/view/gs/gardener-prow/logs/post-gardener-build-dev-images/1513834382115213312

~ docker run --rm eu.gcr.io/gardener-project/gardener/apiserver:v1.45.0-dev-f5882800d5821bcc18198da96324bbe013bb1afe --version                                                                                                                (gardener-prow-trusted/default)
Unable to find image 'eu.gcr.io/gardener-project/gardener/apiserver:v1.45.0-dev-f5882800d5821bcc18198da96324bbe013bb1afe' locally
v1.45.0-dev-f5882800d5821bcc18198da96324bbe013bb1afe: Pulling from gardener-project/gardener/apiserver
5758d4e389a3: Already exists
fd2d5834177c: Pull complete
1ab5ad74e424: Pull complete
Digest: sha256:89671e05c1d5e1b91b58edc898a9c90a1742cd30ef21453b6056ad2844f1b04b
Status: Downloaded newer image for eu.gcr.io/gardener-project/gardener/apiserver:v1.45.0-dev-f5882800d5821bcc18198da96324bbe013bb1afe
Gardener v1.45.0-dev-f5882800d5821bcc18198da96324bbe013bb1afe

@gardener-prow gardener-prow bot added the kind/bug Bug label Apr 12, 2022
@gardener-prow gardener-prow bot requested review from rfranzke and timebertt April 12, 2022 11:13
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2022
@oliver-goetz
Copy link
Member Author

/cla

@gardener-prow
Copy link

gardener-prow bot commented Apr 12, 2022

Successfully reached out to cla-assistant.io to initialize recheck of PR #190

@timebertt
Copy link
Member

/cla

@gardener-prow
Copy link

gardener-prow bot commented Apr 12, 2022

Successfully reached out to cla-assistant.io to initialize recheck of PR #190

@timebertt
Copy link
Member

/override license/cla

@gardener-prow
Copy link

gardener-prow bot commented Apr 12, 2022

@timebertt: Overrode contexts on behalf of timebertt: license/cla

In response to this:

/override license/cla

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-prow gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Apr 12, 2022
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow
Copy link

gardener-prow bot commented Apr 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 12, 2022
@timebertt
Copy link
Member

ref #180

@gardener-prow gardener-prow bot merged commit 94ae288 into gardener:master Apr 12, 2022
@oliver-goetz oliver-goetz deleted the inject-effective-version branch April 12, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants