-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable 'hg push' to TS repositories #2033
Conversation
@@ -75,6 +75,9 @@ def __call__( self, environ, start_response ): | |||
connection.execute( sql_cmd ) | |||
connection.close() | |||
elif cmd in [ 'unbundle', 'pushkey' ]: | |||
if self.config[ 'disable_push' ]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/self.config[ 'disable_push' ]/self.config.get('disable_push', True)/
Should fix the traceback in https://jenkins.galaxyproject.org/job/docker-toolshed/1994/testReport/junit/tool_shed.functional.test_0310_hg_push_from_api/TestHgWebFeatures/test_0010_edit_and_commit/ :
File "/galaxy/lib/galaxy/webapps/tool_shed/framework/middleware/hg.py", line 78, in __call__
if self.config[ 'disable_push' ]:
KeyError: 'disable_push'
I've opened a PR against your branch in martenson#13 . |
Fixes for "Remove hg direct api"
this is a WIP; I am writing more tests |
reopened as #2044 |
deprecated in 15.10 https://docs.galaxyproject.org/en/master/releases/15.10_announce.html#deprecation-notices
results in
This also adds a TS configuration option
disable_push
that defaults toTrue
part of #1928