Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.2] Fix workflows with optional non-default parameter input #19332

Merged
merged 6 commits into from
Jan 7, 2025
Merged

[24.2] Fix workflows with optional non-default parameter input #19332

merged 6 commits into from
Jan 7, 2025

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Dec 16, 2024

where input not provided. Fixes #19328

Broken in #19219. Caught this using the weekly iwc tests against the release_24.2 branch.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.0 milestone Dec 16, 2024
@mvdbeek mvdbeek force-pushed the fix_null_replacement branch from 742054e to 8262dad Compare December 16, 2024 16:53
@mvdbeek mvdbeek marked this pull request as draft December 16, 2024 18:07
@mvdbeek mvdbeek force-pushed the fix_null_replacement branch from e94d2f7 to 993ad97 Compare December 17, 2024 15:02
@mvdbeek mvdbeek force-pushed the fix_null_replacement branch 3 times, most recently from ea21099 to b89f4fe Compare December 18, 2024 15:50
@mvdbeek mvdbeek force-pushed the fix_null_replacement branch from eba87e0 to 2df6577 Compare December 19, 2024 11:51
@mvdbeek
Don't replace default values too early
7a7836e 
We should probably only do this once we're ready to execute the step,
not when injecting modules and building the tool state.
@mvdbeek mvdbeek force-pushed the fix_null_replacement branch from 2df6577 to 7a7836e Compare December 20, 2024 10:10
@mvdbeek mvdbeek marked this pull request as ready for review December 20, 2024 11:47
@mvdbeek
Copy link
Member Author

mvdbeek commented Dec 20, 2024

I don't love the changes in visit_input_values, but this probably works well enough ? It does fix #19328: https://github.com/galaxyproject/iwc/actions/runs/12430553718/job/34706387383

@mvdbeek mvdbeek requested a review from jmchilton December 20, 2024 11:57
@mvdbeek mvdbeek modified the milestones: 25.0, 24.2 Dec 20, 2024
@jmchilton jmchilton merged commit f8ae3ce into galaxyproject:release_24.2 Jan 7, 2025
48 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton Awaiting requested review from jmchilton

Assignees
No one assigned
Labels
area/testing area/workflows kind/bug
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mvdbeek @jmchilton