Strip galaxy filename annotation on upload

[GomeChas]

Issue #17642

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests. Wishing for guidance on the tests still...
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[ahmedhamidawan]

The forced confirmation dialogue isn't ideal here.
A better alternative could be a Toast that has a button/link in it?
Examples of Toasts being used are in components with the import:

import { Toast } from "@/composables/toast";

[ahmedhamidawan]

Used our existing confirmDialog composable here instead:

strip_galaxy_filename_annotation_on_upload.mp4

This is still a dialog that though can be dismissed easily; if we still think this is still potentially in the user's way, we could try something else.

[GomeChas]

@ahmedhamidawan I like how the message box appropriately pops up within the confirmDialog component. TY for that one!

[martenson]

if we still think this is still potentially in the user's way, we could try something else.

I do. imho the stripping should just happen, it is hard to imagine a situation where users don't want to do it.

Additionally, handling this through extra modal for multiple files at once would be confusing at least.

[jennaj]

We could just make it automatically stripped and see if anyone complains?

Or, maybe strip automatically and put the original name into the file description? Sort of like a log of provenance? I would like this a lot. Maybe something like: Uploaded as [original file name] on DATE-timestamp

or make it really log-like

Universal-DATE action original-filename

2024000000 Upload Galaxy-filename[whatever].bam

I think all actions on a dataset under Edit Attr should be logged there but .. not asking for that, just this :) and leaves room to log more label/metadata actions in later.

And -- operations on multiple datasets could have a batch action "simplify dataset names" and this could be one of the actions.

I'll stop now!

[ahmedhamidawan]

Removed any confirmation dialogs and enforced rename if it is potentially a Galaxy file:

@jennaj I do like the option you've mentioned of adding the fact that it was renamed to the file's metadata