Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Make default_panel_view a _by_host option #18471

Merged

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Jun 29, 2024

How to test the changes?

(Select all options that apply)

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@galaxyproject-sentryintegration

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: lib/galaxy/tool_util/toolbox/base.py

Function Unhandled Issue
__init__ AttributeError: 'ToolPanelViewModel' object has no attribute 'id' galaxy.tool_util.toolbox...
Event Count: 12
__init__ ValidationError: 24 validation errors for StaticToolBoxView galaxy.tool_util.toolbox.views.definitions i...
Event Count: 5

Did you find this useful? React with a 👍 or 👎

@natefoo natefoo changed the base branch from dev to release_24.1 June 30, 2024 05:29
@natefoo natefoo changed the title Make default_panel_view a _by_host option [24.1] Make default_panel_view a _by_host option Jun 30, 2024
@jmchilton jmchilton force-pushed the default-panel-view-by-host branch from cbab5ec to 1111822 Compare July 1, 2024 05:05
@mvdbeek mvdbeek merged commit ed81681 into galaxyproject:release_24.1 Jul 3, 2024
46 of 49 checks passed
Copy link

github-actions bot commented Jul 3, 2024

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants