Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the About Page #18461

Merged
merged 3 commits into from
Jun 29, 2024
Merged

Updates the About Page #18461

merged 3 commits into from
Jun 29, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Jun 28, 2024

Follow-up to #17927. Updates the About page to:

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.2 milestone Jun 28, 2024
@guerler guerler requested a review from martenson June 28, 2024 13:38
@guerler guerler force-pushed the about_page_update branch from fab7d6e to 292de29 Compare June 28, 2024 14:41
@guerler guerler force-pushed the about_page_update branch from 292de29 to 236b125 Compare June 29, 2024 09:13
@guerler guerler marked this pull request as ready for review June 29, 2024 09:24
@ElectronicBlueberry
Copy link
Member

Please keep one h1 tag on this page, which titles the centre panel

@martenson
Copy link
Member

I am actually a big fan of using the external link icon, even though we do not use it consistently in the UI yet, however for this page it feels like a really dominant part of it. Not quite sure how to improve it though.

@guerler guerler merged commit 2e0874c into galaxyproject:dev Jun 29, 2024
31 checks passed
@guerler guerler deleted the about_page_update branch June 29, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants