Merge 24.1 #18386
Merged
Merge 24.1 #18386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like it would also help with galaxyproject/pulsar#364. It probably fixes galaxyproject#18347.
This passes the version prop to the routes for editing and running workflows and also to the `InvokeWorkflowPayload`, so that users can run specific versions of workflows. Fixes galaxyproject#18367
Show the name corresponding to the `WorkflowRun` form workflow's version.
And fix test that was supposed to cover this. Fixes galaxyproject#18384
…un_edit_for_version [24.1] Allow running and editing workflows for specific versions
Otherwise revision details are displayed in list output: INCORRECT: 92fb564c7095 -> ddbdbc40bdc1 (gxy), add workflow_comment table Revision ID: ddbdbc40bdc1 Revises: 92fb564c7095 Create Date: 2023-08-14 13:41:59.442243 987ce9839ecb, e93c5d0b47a9 -> 92fb564c7095 (gxy) (mergepoint), Merge alembic heads after pulling external_user_id length extension forward EXPECTED: 92fb564c7095 -> ddbdbc40bdc1 (gxy), add workflow_comment table 987ce9839ecb, e93c5d0b47a9 -> 92fb564c7095 (gxy) (mergepoint), Merge alembic heads after pulling external_user_id length extension forward
The bug was introduced when moving this code to SQLAlchemy 2.0 The statement in generate_next_available_username should be evaluated at each step of the iteration: only then will the new value of `i` result in a new statement.
…f_still_running [24.0] Kill pulsar job if job stopped on galaxy side
…check [24.0] Fix null inputs in database operation tools
…in_db [24.1] Fix empty usernames in database + bug in username generation
github-actions
bot
added
area/UI-UX
area/jobs
area/database
|
The failures are due to db migrations (new migrations in dev + new migration in 24.1 => multiple heads; need a merge migration). I'll fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)
How to test the changes?
(Select all options that apply)
License