Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Fix missing grep input in sort1 tool #16910

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 24, 2023

Cherry-picked out of #15229

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Oct 24, 2023
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

If you have an idea how to get tools that are listed in any of the tool conf files tested (and maybe even lined).. Then please comment in the linked PR

@mvdbeek
Copy link
Member Author

mvdbeek commented Oct 24, 2023

I don't know that we should test or update the tools except for blatant bugs like this one, which you can just planemo test.

@nsoranzo nsoranzo merged commit 2bf0601 into galaxyproject:release_23.1 Oct 24, 2023
38 checks passed
@nsoranzo nsoranzo deleted the sort1_fix branch October 24, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants