Fix navigation error in tool shed tests. #16902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
fix_ts_tests
branch
2 times, most recently
from
886ac29 to
d3024f1
Compare
|
Got lost on a red herring at first - I think all the problems are just the navigation issues. I think what is happening here is the logout has a race condition. The failures seem to happen on the second login within two of the same test method. I think the logout redirect with conflicting with the goto. There are a number of ways to work around this - I'm not sure it is worth putting too much effort into getting it perfect - certainly the tests that initialize different sessions for different logins are going to be entirely robust against this. |
|
My guess is https://github.com/galaxyproject/galaxy/blob/dev/lib/tool_shed/webapp/frontend/src/stores/auth.store.ts#L49 is the frontend redirect that is conflicting with the playwright commands. |
jmchilton
force-pushed
the
fix_ts_tests
branch
from
d3024f1 to
2d663e9
Compare
mvdbeek
approved these changes
Oct 24, 2023
jmchilton
force-pushed
the
fix_ts_tests
branch
from
2d663e9 to
0d67562
Compare
jmchilton
changed the title
nsoranzo
reviewed
Oct 24, 2023
lib/tool_shed/test/functional/test_0030_repository_dependency_revisions.py
Outdated
Show resolved
Hide resolved
jmchilton
force-pushed
the
fix_ts_tests
branch
from
0d67562 to
e14a369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure I correctly identified the problem in comments and I've fixed it two different ways.
How to test the changes?
(Select all options that apply)
License