[23.0] celery_extended doesn't update disk usage for work dir outputs. #14055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
broken_disk_usage_update
branch
from
e874199 to
55ffaff
Compare
…oken with celery_extended.
jmchilton
force-pushed
the
broken_disk_usage_update
branch
from
55ffaff to
e3cac30
Compare
mvdbeek
changed the title
dannon
changed the title
davelopez
reviewed
Apr 6, 2023
| @classmethod | ||
| def handle_galaxy_config_kwds(cls, config): | ||
| super().handle_galaxy_config_kwds(config) | ||
| config["metadata_strategy"] = "celery_extended" |
There was a problem hiding this comment.
I was just trying this, as suggested by Marius, to see if this was somehow related to a possible issue when using Celery that I'm currently investigating (#15821).
What I found out about this is that when the metadata_strategy is set to directory or directory_celery both test success, and they fail with extended and extended_celery so it seems that Celery is not the cause of this problem but something with the extended metadata strategy itself.
4 tasks
|
Pretty sure we fixed this in #16109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far just a test case to demonstrate disk usage update for work dir outputs is broken with celery_extended - the test case works by default but fails for celery_extended.
Discovered this working on quota stuff.
Open questions...
How to test the changes?
(Select all options that apply)
License