Try to disable transaction helper

If this does not break transactional state, this helper should be removed completely.
galaxyproject · Jan 8, 2025 · 5f4090b · 5f4090b
1 parent 9e38cae
commit 5f4090b
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/lib/galaxy/model/base.py b/lib/galaxy/model/base.py
@@ -52,11 +52,12 @@ def transaction(session: Union[scoped_session, Session, "SessionlessContext"]):
         yield
         return  # exit: can't use as a Session
 
-    if not session.in_transaction():  # type:ignore[union-attr]
-        with session.begin():  # type:ignore[union-attr]
-            yield
-    else:
-        yield
+    yield  # TODO once we can verify this does not break SQLAlchemy transactions, remmove this helper completely (561 instances)
+    # if not session.in_transaction():  # type:ignore[union-attr]
+    #    with session.begin():  # type:ignore[union-attr]
+    #        yield
+    # else:
+    #    yield
 
 
 def check_database_connection(session):