Skip to content

Commit

Permalink
Merge pull request #18388 from itisAliRH/dataset-pooling-rerender-fix
Browse files Browse the repository at this point in the history
[24.1] Fix dataset details polling re-render
  • Loading branch information
mvdbeek authored Jun 13, 2024
2 parents 222a2aa + 092b77f commit 5c68108
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions client/src/components/DatasetInformation/DatasetDetails.vue
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const userStore = useUserStore();
const { currentUser } = storeToRefs(userStore);
const loading = ref(false);
const jobLoading = ref(true);
const jobTimeOut = ref<any>(null);
const jobDetails = ref<JobDetails>();
const dataset = ref<HDADetailed | null>(null);
Expand All @@ -57,8 +56,6 @@ async function getDatasetDetails() {
}
async function loadJobDetails() {
jobLoading.value = true;
try {
const { data } = await fetchJobDetails({ job_id: dataset.value?.creating_job as string, full: true });
Expand All @@ -73,8 +70,6 @@ async function loadJobDetails() {
const error = e as AxiosError<{ err_msg?: string }>;
jobLoadingError.value = error.response?.data?.err_msg || "Unable to fetch available dataset details.";
} finally {
jobLoading.value = false;
}
}
Expand Down Expand Up @@ -102,7 +97,7 @@ onUnmounted(() => {
{{ datasetLoadingError }}
</BAlert>
<div v-else-if="dataset">
<div v-if="dataset.creating_job && !jobLoading" class="details">
<div v-if="dataset.creating_job" class="details">
<DatasetInformation :dataset="dataset" />

<JobParameters dataset_type="hda" :dataset-id="datasetId" />
Expand All @@ -124,7 +119,7 @@ onUnmounted(() => {

<JobDestinationParams v-if="currentUser?.is_admin" :job-id="dataset.creating_job" />

<JobDependencies v-if="jobDetails.dependencies" :dependencies="jobDetails.dependencies" />
<JobDependencies v-if="jobDetails?.dependencies" :dependencies="jobDetails.dependencies" />

<div v-if="dataset.peek">
<h2 class="h-md">Dataset Peek</h2>
Expand Down

0 comments on commit 5c68108

Please sign in to comment.