Default value making input optional is unfrotunately not backwards co…

…mpatible
galaxyproject · Sep 8, 2024 · 1bbfc9c · 1bbfc9c
1 parent 17bda9d
commit 1bbfc9c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/galaxy/workflow/run.py b/lib/galaxy/workflow/run.py
@@ -570,7 +570,7 @@ def set_outputs_for_input(
             step_id = step.id
             if step_id not in self.inputs_by_step_id and "output" not in outputs:
                 default_value = step.input_default_value
-                if default_value or step.input_optional:
+                if step.default_value_set:
                     outputs["output"] = default_value
                 else:
                     log.error(f"{step.log_str()} not found in inputs_step_id {self.inputs_by_step_id}")

diff --git a/lib/galaxy_test/base/workflow_fixtures.py b/lib/galaxy_test/base/workflow_fixtures.py
@@ -617,6 +617,7 @@
   int_input:
     type: integer
     default: 3
+    optional: true
 steps:
   random:
     tool_id: random_lines1