Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add integration test helper #991

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enthusiastmartin
Copy link
Contributor

No description provided.

Copy link

Crate versions that have been updated:

  • runtime-integration-tests: v1.30.0 -> v1.31.0

Runtime version has not been increased.

}

impl HydrationTestDriver {
pub(crate) fn add_omnipool_assets(self, assets: Vec<AssetId>) -> Self {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason that there are two implementation block for HydrationTestDriver?

}
}

impl HydrationTestDriver {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just call it IntegrationTestBase or similar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants