feat(xcm): add xcm topic id wrappers to router and barrier #961
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jak-pan
approved these changes
Dec 30, 2024
|
We need rebench here and we can merge. @XY-Wang can you send your wallet address? |
|
@XY-Wang Please adjust the failing test and bump the necessary versions, then we are good to go. |
|
Merged from master and fixed the failing test. You can use the address 152n2TXMkYa2oLgNyDK1H7X7D3WFjoShVCSUBceATccjTzza. Thanks and happy new year! |
|
Hi @dmoka, I fixed the formatting and bumped the versions that were causing the pipeline to fail. Please try to run it again, sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
WithUniqueTopicandTrailingSetTopicAsIdwrappers, introduced in paritytech/polkadot#7234, to the XCM Router and Barrier respectively.This will allow for easier tracking of XCM, especially in the case of multi-hop messages where the message hash differs on each leg.
More detailed explanation: https://substrate.stackexchange.com/questions/1893/is-there-an-id-for-xcm-message/1906#1906
The implementation mirrors that of the system parachains:
https://github.com/polkadot-fellows/runtimes/blob/7b096c14c2b16cc81ca4e2188eea9103f120b7a4/system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs#L295
https://github.com/polkadot-fellows/runtimes/blob/7b096c14c2b16cc81ca4e2188eea9103f120b7a4/system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs#L477