Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better PHP 8.4 support #323

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Better PHP 8.4 support #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e2bd03
release: 1.9.1
Chemaclass Dec 12, 2024
5351b44
test: fix DocBlockResolverCustomServicesAwareTest
Chemaclass Dec 12, 2024
62cb6d9
fix: tests running on php 8.4
Chemaclass Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [1.9.1](https://github.com/gacela-project/gacela/compare/1.9.0...1.9.1) - 2024-12-12

- Better compatibility with PHP 8.4

## [1.9.0](https://github.com/gacela-project/gacela/compare/1.8.1...1.9.0) - 2024-12-01

- Compatibility with PHP 8.4
Expand Down
2 changes: 0 additions & 2 deletions tests/Feature/Framework/ListeningEvents/ClassResolver/DisableListenersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,11 @@
use Gacela\Framework\Gacela;
use GacelaTest\Feature\Framework\ListeningEvents\ClassResolver\Module\Facade;
use PHPUnit\Framework\Attributes\PreserveGlobalState;
use PHPUnit\Framework\Attributes\RunInSeparateProcess;
use PHPUnit\Framework\TestCase;
use RuntimeException;

final class DisableListenersTest extends TestCase
{
#[RunInSeparateProcess]
#[PreserveGlobalState(false)]
public function test_disable_class_resolver_listener(): void
{
Expand Down
7 changes: 0 additions & 7 deletions tests/Feature/Framework/StaticFacade/FeatureTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
use GacelaTest\Feature\Framework\StaticFacade\ModuleB\Facade as TestObjectFacade;
use GacelaTest\Feature\Framework\StaticFacade\ModuleB\Factory as ObjectFactory;
use PHPUnit\Framework\Attributes\PreserveGlobalState;
use PHPUnit\Framework\Attributes\RunInSeparateProcess;
use PHPUnit\Framework\TestCase;

final class FeatureTest extends TestCase
Expand All @@ -20,7 +19,6 @@ protected function setUp(): void
Gacela::bootstrap(__DIR__);
}

#[RunInSeparateProcess]
#[PreserveGlobalState(false)]
public function test_unknown_static_facade_method(): void
{
Expand All @@ -29,7 +27,6 @@ public function test_unknown_static_facade_method(): void
TestStaticFacade::unknown();
}

#[RunInSeparateProcess]
#[PreserveGlobalState(false)]
public function test_unknown_object_factory_method(): void
{
Expand All @@ -38,7 +35,6 @@ public function test_unknown_object_factory_method(): void
(new TestObjectFacade())->unknown();
}

#[RunInSeparateProcess]
#[PreserveGlobalState(false)]
public function test_unknown_static_factory_method(): void
{
Expand All @@ -47,7 +43,6 @@ public function test_unknown_static_factory_method(): void
TestStaticFacade::unknownFacadeMethod();
}

#[RunInSeparateProcess]
#[PreserveGlobalState(false)]
public function test_module_a_static_facade(): void
{
Expand All @@ -56,7 +51,6 @@ public function test_module_a_static_facade(): void
self::assertSame(StaticFactory::STR, $actual);
}

#[RunInSeparateProcess]
#[PreserveGlobalState(false)]
public function test_module_a_object_facade(): void
{
Expand All @@ -65,7 +59,6 @@ public function test_module_a_object_facade(): void
self::assertSame(ObjectFactory::STR, $actual);
}

#[RunInSeparateProcess]
#[PreserveGlobalState(false)]
public function test_factory_static_facade_method(): void
{
Expand Down
1 change: 1 addition & 0 deletions ...s/Integration/Framework/DocBlockResolverAware/DocBlockResolverCustomServicesAwareTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ protected function setUp(): void
{
Gacela::bootstrap(__DIR__, static function (GacelaConfig $config): void {
$config->resetInMemoryCache();
$config->enableFileCache(__DIR__);
$config->addAppConfigKeyValue(GacelaFileCache::KEY_ENABLED, true);
$config->registerGenericListener(static function (GacelaEventInterface $event): void {
// dump('Triggered -> ' . \get_class($event)); # useful for debugging
Expand Down
Loading