refactor: simplify Config->getCacheDir()

gacela-project · Dec 1, 2024 · 810bd6e · 810bd6e
1 parent 78317ec
commit 810bd6e
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/src/Framework/Config/Config.php b/src/Framework/Config/Config.php
@@ -10,7 +10,6 @@
 use RuntimeException;
 
 use function array_key_exists;
-use function is_string;
 
 final class Config implements ConfigInterface
 {
@@ -126,16 +125,11 @@ public function getCacheDir(): string
             return $this->cacheDir;
         }
 
-        $cacheDir = getenv('GACELA_CACHE_DIR');
-        if (is_string($cacheDir)) {
-            $this->cacheDir = rtrim($cacheDir, DIRECTORY_SEPARATOR);
-            return $this->cacheDir;
-        }
-
-        $this->cacheDir = $this->getAppRootDir()
+        $this->cacheDir = getenv('GACELA_CACHE_DIR') ?: $this->getAppRootDir()
             . DIRECTORY_SEPARATOR
             . ltrim($this->setup->getFileCacheDirectory(), DIRECTORY_SEPARATOR);
-        return $this->cacheDir;
+
+        return rtrim($this->cacheDir, DIRECTORY_SEPARATOR);
     }
 
     /**