Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(er): import er resource, unit tests and docs #193

Closed

Conversation

Zhukun-Huawei
Copy link
Contributor

@Zhukun-Huawei Zhukun-Huawei commented Dec 21, 2023

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

=== RUN   TestAccDataSourceAZs_basic
=== PAUSE TestAccDataSourceAZs_basic
=== CONT  TestAccDataSourceAZs_basic
--- PASS: TestAccDataSourceAZs_basic (18.28s)
PASS

coverage: 8.0% of statements in ../../../../../terraform-provider-g42cloud/...
=== RUN   TestAccInstancesDataSource_basic

=== PAUSE TestAccInstancesDataSource_basic

=== CONT  TestAccInstancesDataSource_basic

--- PASS: TestAccInstancesDataSource_basic (67.80s)
PASS

coverage: 8.3% of statements in ../../../../../terraform-provider-g42cloud/...
=== RUN   TestAccInstancesDataSource_filterById
=== PAUSE TestAccInstancesDataSource_filterById
=== CONT  TestAccInstancesDataSource_filterById
--- PASS: TestAccInstancesDataSource_filterById (69.43s)
PASS

coverage: 8.3% of statements in ../../../../../terraform-provider-g42cloud/...
=== RUN   TestAccInstancesDataSource_filterByStatus
=== PAUSE TestAccInstancesDataSource_filterByStatus
=== CONT  TestAccInstancesDataSource_filterByStatus
--- PASS: TestAccInstancesDataSource_filterByStatus (65.05s)
PASS

coverage: 8.3% of statements in ../../../../../terraform-provider-g42cloud/...
=== RUN   TestAccInstancesDataSource_filterByEpsId
=== PAUSE TestAccInstancesDataSource_filterByEpsId
=== CONT  TestAccInstancesDataSource_filterByEpsId
--- PASS: TestAccInstancesDataSource_filterByEpsId (68.77s)
PASS

coverage: 8.3% of statements in ../../../../../terraform-provider-g42cloud/...

=== RUN   TestAccInstancesDataSource_filterByTags
=== PAUSE TestAccInstancesDataSource_filterByTags
=== CONT  TestAccInstancesDataSource_filterByTags
--- PASS: TestAccInstancesDataSource_filterByTags (64.10s)
PASS

coverage: 8.3% of statements in ../../../../../terraform-provider-g42cloud/...
=== RUN   TestAccRouteTablesDataSource_basic
=== PAUSE TestAccRouteTablesDataSource_basic
=== CONT  TestAccRouteTablesDataSource_basic
--- PASS: TestAccRouteTablesDataSource_basic (103.57s)
PASS

coverage: 8.3% of statements in ../../../../../terraform-provider-g42cloud/...
=== RUN   TestAccRouteTablesDataSource_byName
=== PAUSE TestAccRouteTablesDataSource_byName
=== CONT  TestAccRouteTablesDataSource_byName
--- PASS: TestAccRouteTablesDataSource_byName (97.33s)
PASS

coverage: 8.3% of statements in ../../../../../terraform-provider-g42cloud/...
=== RUN   TestAccRouteTablesDataSource_byId
=== PAUSE TestAccRouteTablesDataSource_byId
=== CONT  TestAccRouteTablesDataSource_byId
--- PASS: TestAccRouteTablesDataSource_byId (93.89s)
PASS
coverage: 8.3% of statements in ../../../../../terraform-provider-g42cloud/...
=== RUN   TestAccRouteTablesDataSource_byTags
=== PAUSE TestAccRouteTablesDataSource_byTags
=== CONT  TestAccRouteTablesDataSource_byTags
--- PASS: TestAccRouteTablesDataSource_byTags (102.31s)
PASS

coverage: 8.3% of statements in ../../../../../terraform-provider-g42cloud/...
=== RUN   TestAccInstance_basic
=== PAUSE TestAccInstance_basic
=== CONT  TestAccInstance_basic
--- PASS: TestAccInstance_basic (89.48s)
PASS
coverage: 11.2% of statements in ../../../../../terraform-provider-g42cloud/...
=== RUN   TestAccRouteTable_basic
=== PAUSE TestAccRouteTable_basic
=== CONT  TestAccRouteTable_basic
--- PASS: TestAccRouteTable_basic (123.24s)
PASS

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 21, 2023
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-ci-robot
Copy link
Collaborator

PR needs rebase.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-ci-robot
Copy link
Collaborator

PR needs rebase.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Comment on lines 470 to 479
"g42cloud_identity_role_assignment": iam.ResourceIdentityGroupRoleAssignment(),
"g42cloud_identity_user": iam.ResourceIdentityUser(),
"g42cloud_identity_group": iam.ResourceIdentityGroup(),
"g42cloud_identity_group_membership": iam.ResourceIdentityGroupMembership(),
"g42cloud_identity_acl": iam.ResourceIdentityACL(),
"g42cloud_identity_agency": iam.ResourceIAMAgencyV3(),
"g42cloud_identity_project": iam.ResourceIdentityProject(),
"g42cloud_identity_provider": iam.ResourceIdentityProvider(),
"g42cloud_identity_provider_conversion": iam.ResourceIAMProviderConversion(),
"g42cloud_identity_role": iam.ResourceIdentityRole(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"g42cloud_identity_role_assignment": iam.ResourceIdentityGroupRoleAssignment(),
"g42cloud_identity_user": iam.ResourceIdentityUser(),
"g42cloud_identity_group": iam.ResourceIdentityGroup(),
"g42cloud_identity_group_membership": iam.ResourceIdentityGroupMembership(),
"g42cloud_identity_acl": iam.ResourceIdentityACL(),
"g42cloud_identity_agency": iam.ResourceIAMAgencyV3(),
"g42cloud_identity_project": iam.ResourceIdentityProject(),
"g42cloud_identity_provider": iam.ResourceIdentityProvider(),
"g42cloud_identity_provider_conversion": iam.ResourceIAMProviderConversion(),
"g42cloud_identity_role": iam.ResourceIdentityRole(),
"g42cloud_identity_provider": iam.ResourceIdentityProvider(),
"g42cloud_identity_provider_conversion": iam.ResourceIAMProviderConversion(),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-ci-robot
Copy link
Collaborator

PR needs rebase.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@chengxiangdong
Copy link
Collaborator

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants