-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gluon-v2023.2.x] patches: ath79: fix reset sequence for AR9344 #545
[gluon-v2023.2.x] patches: ath79: fix reset sequence for AR9344 #545
Conversation
with upstream you mean openwrt? |
Currently, there is an open PR for gluon (which from our point of view is already upstream in some sense). This PR was OK'ed and should be done against OpenWRT (the upstream of Gluon). But long term should be to bring it into linux-next (the kernel upstream, the upstream of OpenWRT, the final upstream). Our patch here is against Gluon v2023.2.x which is based on OpenWRT 23.05, i.e. kernel 5.15. |
then i think we should bring it atm also in our gluon-next patch folder so that we dont forget it whatever happens next with the patch EDIT: |
Do you think we should make a gluon-next release soon? Didn't plan to, but we could. I would focus on the v2023.2.x migration first. |
no release but just put it in there so we dont forget it or? |
I was hoping upstream gluon might be faster than our release 😅. Especially because there won't be any affected devices that require gluon-next. But we can make a PR, it won't hurt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
it's not about gluon, has to be fixed in openwrt and so far no one bothered to create a PR there ;-) |
@T0biii here is the PR including the upstream fix: freifunk-gluon/gluon#3411 modules: update openwrt |
This is a backport to Gluon v2023.2.x of the "upstream" PR freifunk-gluon/gluon#3397
I manually tested this on a WR4300 and got 150+ successful reboots with the patch and <20 without the patch.
Gluon v2023.1.x is also affected, but with the upcoming firmware release with Gluon v2023.2.x I don't see a benefit of putting time into another backport.
For Gluon-next we can just wait for the upstream PR to be merged.
What do you think @T0biii ?