Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gluon-v2023.2.x] patches: ath79: fix reset sequence for AR9344 #545

Conversation

grische
Copy link
Contributor

@grische grische commented Jan 2, 2025

This is a backport to Gluon v2023.2.x of the "upstream" PR freifunk-gluon/gluon#3397

I manually tested this on a WR4300 and got 150+ successful reboots with the patch and <20 without the patch.

Gluon v2023.1.x is also affected, but with the upcoming firmware release with Gluon v2023.2.x I don't see a benefit of putting time into another backport.

For Gluon-next we can just wait for the upstream PR to be merged.

What do you think @T0biii ?

@grische grische requested review from maurerle and a team as code owners January 2, 2025 18:58
@grische grische changed the title patches: ath79: fix reset sequence for AR9344 [Gluon v2023.2.x] patches: ath79: fix reset sequence for AR9344 Jan 2, 2025
@grische grische changed the title [Gluon v2023.2.x] patches: ath79: fix reset sequence for AR9344 [gluon-v2023.2.x] patches: ath79: fix reset sequence for AR9344 Jan 2, 2025
@T0biii
Copy link
Member

T0biii commented Jan 2, 2025

with upstream you mean openwrt?

@grische
Copy link
Contributor Author

grische commented Jan 2, 2025

Currently, there is an open PR for gluon (which from our point of view is already upstream in some sense). This PR was OK'ed and should be done against OpenWRT (the upstream of Gluon). But long term should be to bring it into linux-next (the kernel upstream, the upstream of OpenWRT, the final upstream).

Our patch here is against Gluon v2023.2.x which is based on OpenWRT 23.05, i.e. kernel 5.15.
The Gluon PR uses gluon-master as target which is based on OpenWRT 24.10, i.e. kernel 6.6.
OpenWRT master currently still uses kernel 6.6, but this might change to 6.12?
linux-next will probably be 6.14 if we're lucky or 6.15 if it takes longer.

@T0biii
Copy link
Member

T0biii commented Jan 2, 2025

then i think we should bring it atm also in our gluon-next patch folder so that we dont forget it whatever happens next with the patch

EDIT:
and i wont backport it to v2023.1.x they should update to v2023.2.x

@grische
Copy link
Contributor Author

grische commented Jan 2, 2025

Do you think we should make a gluon-next release soon? Didn't plan to, but we could. I would focus on the v2023.2.x migration first.

@T0biii
Copy link
Member

T0biii commented Jan 2, 2025

no release but just put it in there so we dont forget it or?

@grische
Copy link
Contributor Author

grische commented Jan 2, 2025

I was hoping upstream gluon might be faster than our release 😅. Especially because there won't be any affected devices that require gluon-next. But we can make a PR, it won't hurt.

Copy link
Member

@T0biii T0biii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grische grische merged commit a8d21fb into freifunkMUC:gluon-v2023.2.x Jan 3, 2025
33 checks passed
@grische grische deleted the patch/ath79-fix-reset-sequence-for-ar9344 branch January 3, 2025 01:04
@rotanid
Copy link
Contributor

rotanid commented Jan 3, 2025

I was hoping upstream gluon might be faster than our release 😅. Especially because there won't be any affected devices that require gluon-next. But we can make a PR, it won't hurt.

it's not about gluon, has to be fixed in openwrt and so far no one bothered to create a PR there ;-)

@grische
Copy link
Contributor Author

grische commented Jan 7, 2025

@T0biii here is the PR including the upstream fix: freifunk-gluon/gluon#3411

modules: update openwrt
0c52c9d6fc ath79: reset ETH switch for AR9344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants