gluon-private-wifi: rename psk3 to sae as it is used in openwrt that way #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
3. topic: package
maurerle
force-pushed
the
rename_wpa3_sae
branch
from
964dae5 to
7e9a44b
Compare
|
You need a migration as the current state display in the frontend is used as the identifier. |
rotanid
added
the
2. status: blocked
|
Isn't it enough to replace the string when setting the default like I do in this PR? |
Would be cleaner to migrate it once in an upgrade script instead of keeping the string replacement in the UI forever. |
|
I'm with @neocturne on this - Your approach would need to be kept indefinitely while a migration can be removed at one point in the future. |
add proper migration for older uci setting Signed-off-by: Florian Maurer <f.maurer@outlook.de>
maurerle
force-pushed
the
rename_wpa3_sae
branch
from
7e9a44b to
8b0953a
Compare
maurerle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a hard time finding information about psk3 in openwrt documentation as it is not mentioned here:
https://openwrt.org/docs/guide-user/network/wifi/basic#encryption_modes
I think the naming changed some time, so it makes sense to use the documented value of sae instead of psk3.
The functionality in openwrt is the same, so this does not change any functionality
and there is no good reason to migrate existing configs.Though this helps to better find related documentation to the value set in
uci show wireless