feat!: columns in dynamic containers #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is continuation of the frappe#205 PR. There are some issue with PDF generated by table component and I am working on it. I will update the PR once I fix the issue.
maharshivpatel
force-pushed
the
feat-columns-in-dynamic-containers
branch
from
c3d50ed to
0feed51
Compare
wkhtmltopdf have issue with table header overlapping if it is inside a div with display: inline. wkhtmltopdf doesn't support flex but it has some old experimental support for https://developer.mozilla.org/en-US/docs/Web/CSS/box-align As it doesn't support proper implementation of flex it is not used anywhere in print designer. This PR uses display: -webkit-box; to fix the particular issue. hopefully can be used to add more features in the future.
This was used to debug the layout while developing the feature. There will be feature where user can modify/configure the layout soon :D It will be added in a separate PR so not needed as of now.
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing part of #205
This will be merged if I can solve this issue. wkhtmltopdf/wkhtmltopdf#2367
Edit: Solved