Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display suggested proposal params changes [web-desmos] #1311

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

MonikaCat
Copy link
Contributor

@MonikaCat MonikaCat commented Nov 2, 2023

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • ran linting via yarn lint
  • wrote tests where necessary
  • included the correct type prefix in the PR title
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed
  • added a changeset via yarn && yarn changeset

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
cosmos ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 7:04am

@MonikaCat MonikaCat changed the title fix: display suggested proposals params changes [web-desmos] fix: display suggested proposal params changes [web-desmos] Nov 2, 2023
@MonikaCat MonikaCat marked this pull request as ready for review November 2, 2023 05:54
@MonikaCat MonikaCat requested a review from icfor November 2, 2023 06:11
Copy link
Contributor

@icfor icfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just would add the key prop before approving so it is not merged (in case the tag is added later)

@MonikaCat MonikaCat merged commit e749a3b into main Nov 2, 2023
21 checks passed
@MonikaCat MonikaCat deleted the m/update-desmos-proposals-display-v2 branch November 2, 2023 07:35
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants