Show error message when credentials are invalid

[Rainer-Keller]

For regular users it is too complicated to investigate the JSON result from the HTTP request in the debug log.
Showing the message in the UI makes it more obvious.

[flubshi]

Thanks for your contribution @Rainer-Keller :) I think it is a good idea to make the addon more user friendly! Maybe we can also identify other case where a notification makes sense (in separate PRs; afterwards).

Slightly off-topic: I thought about removing the credentials authentication in favor of the device authentication. In that case it will hopefully a bit more user friendly in future.

[Rainer-Keller]

Thanks for your contribution @Rainer-Keller :) I think it is a good idea to make the addon more user friendly! Maybe we can also identify other case where a notification makes sense (in separate PRs; afterwards).

I helped someone to setup Kodi on a Raspberry Pi. This was quite a struggle for various reasons. The other issues are probably not in your plugin.

Slightly off-topic: I thought about removing the credentials authentication in favor of the device authentication. In that case it will hopefully a bit more user friendly in future.

Is there a reason for this?
From the person I helped setting up, they got a letter with credentials to use from their TV provider. It might be confusing if people have never heard of that other process.
Also you should wait until the major help sites like kodi-tipps are featuring the other method as well. Otherwise people will be confused if the help they found on google does not match what they see in the UI.

More off-topic: The used Wifi was sometimes unstable causing the whole UI to freeze in the buffering state forever. The original Waipu stick also had occasional buffering animations but was able to continue playing after a few seconds. Kodi was not. It showed only "stream stalled" in the log, nothing else.
Have you ever seen this? I am not sure if this is a Kodi issue or one in your plugin. Maybe some deadlock between threads? Unfortunately I don't have a Waipu account nor device to test myself. :(

[flubshi]

Is there a reason for this?
From the person I helped setting up, they got a letter with credentials to use from their TV provider. It might be confusing if people have never heard of that other process.
Also you should wait until the major help sites like kodi-tipps are featuring the other method as well. Otherwise people will be confused if the help they found on google does not match what they see in the UI.

Storing credentials in the settings is error-prone. If you change your password on the website, using credential authentication requires to update password in plugin settings.

Another reason: the credentials are not well protected in kodi (e.g. accessible via HTTP API). Not storing the credentials in plugin prevents the from theft and ensures that they also will not appear in logs.

More off-topic: The used Wifi was sometimes unstable causing the whole UI to freeze in the buffering state forever.

I have not noticed that issue related to an unstable Wifi. But it is not related to our plugin. The plugin only handles authentication, grabs data and prepares the stream. Everthing else is handled by kodi. Especially that streaming/buffering is implemented in kodi and inputstream.adaptive. After the stream is started, our plugin is not repsonsible for playback.