fix pylint

floweisshardt · Nov 17, 2020 · 4a9515f · 4a9515f
1 parent 8cd2921
commit 4a9515f
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 11 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -10,7 +10,7 @@ env:
   global:
     - CATKIN_LINT=pedantic
     - NOT_TEST_DOWNSTREAM=true
-    - PYLINT_ARGS="--output-format=parseable --errors-only"
+    - PYLINT_ARGS="--output-format=parseable --errors-only --ignored-modules=tf2_ros"
     - PYLINT2_CHECK=true
     - PYLINT3_CHECK=false
     - PARALLEL_TESTS=false

diff --git a/atf_core/scripts/generate_tests.py b/atf_core/scripts/generate_tests.py
@@ -164,7 +164,7 @@ def generate_tests(self):
                 xml_test({'test-name': "uploading_data",
                         'pkg': "atf_core",
                         'type': "test_dropbox_uploader.py",
-                        'time-limit': str(self.time_limit_uploading),
+                        'time-limit': str(self.atf_configuration_parser.generation_config["time_limit_uploading"]),
                         'args': "-f " + os.path.join(self.package_src_path, "atf/.dropbox_uploader_config") + " upload " + self.atf_configuration_parser.generation_config["bagfile_output"] + " " + os.path.join(self.package_name, "data")}))
 
         if test.generation_config["upload_result"]:

diff --git a/atf_core/src/atf_core/recorder.py b/atf_core/src/atf_core/recorder.py
@@ -83,11 +83,12 @@ def __init__(self, test):
                 topic_type = rostopic._get_topic_type(action + "/goal")[0]
 
                 # remove "Goal" string from action type
-                if topic_type == None or not "Goal" in topic_type:
+                if topic_type == None or not "Goal" in topic_type:  ## pylint: disable=unsupported-membership-test
                     msg = "Could not get type for action %s. type is %s"%(action, topic_type)
                     rospy.logerr(msg)
                     raise ATFRecorderError(msg)
-                topic_type = topic_type[0:len(topic_type)-4] # remove "Goal" from type
+                # remove "Goal" from type
+                topic_type = topic_type[0:len(topic_type)-4] ## pylint: disable=unsubscriptable-object
                 client = SimpleActionClient(action, roslib.message.get_message_class(topic_type))
 
                 # wait for action server

diff --git a/atf_plotter/scripts/plot.py b/atf_plotter/scripts/plot.py
@@ -233,12 +233,6 @@ def plot_benchmark(self, style, sharey, hide_groundtruth, hide_min_max, filter_t
             filter_tests =          argparse_result.test,
             filter_testblocks =     argparse_result.testblock,
             filter_metrics =        argparse_result.metric)
-    elif argparse_result.command == 'plot-series':
-        atf_plotter.plot_series(
-            filter_tests =          argparse_result.test,
-            filter_testblocks =     argparse_result.testblock,
-            filter_metrics =        argparse_result.metric
-        )
     elif argparse_result.command == 'info-structure':
         atf_plotter.print_structure()
     else:

diff --git a/atf_test_tools/src/atf_test_tools/publish_tf.py b/atf_test_tools/src/atf_test_tools/publish_tf.py
@@ -103,7 +103,7 @@ def pub_quadrat(self, length=1, time=1, same_start_stop_orientation=True):
         alpha = math.pi / 2
         r = np.round(
             np.array([
-                [np.cos(alpha), -math.sin(alpha)],
+                [math.cos(alpha), -math.sin(alpha)],
                 [math.sin(alpha), math.cos(alpha)],
             ]),
             6