Fix global phpstan errors #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norberttech
commented
Jan 10, 2025
| - src/adapter/etl-adapter-logger/tests/* | ||
| - src/adapter/etl-adapter-json/tests/* | ||
| - src/adapter/etl-adapter-http/tests/* | ||
| - src/adapter/etl-adapter-csv/tests/* | ||
| - identifier: missingType.iterableValue |
There was a problem hiding this comment.
fixing missingType with phpstan level 8 fixing this issue is pretty much pointless as it can be fixed by adding param array which gives pretty much nothing so we would need to upgrade to level 9 (which I absolutely have no time to deal with, already invested waaaay to much into static analysis for arguable benefits) so if anyone is interested in doing that - feel free
norberttech
commented
Jan 10, 2025
| __DIR__ . '/src/adapter/*/src', | ||
| __DIR__ . '/src/bridge/*/*/src', | ||
| __DIR__ . '/src/tools/*/*/src', | ||
| ]) | ||
| ->withSkipPath(__DIR__ . '/src/lib/parquet/src/Flow/Parquet/Thrift') |
There was a problem hiding this comment.
those are auto-generate classes, they should not be touched
Flow PHP - BenchmarksResults of the benchmarks from this PR are compared with the results from 1.x branch. Extractors+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench | bench_extract_10k | 1 | 3 | 4.742mb +0.03% | 521.236ms +2.49% | ±2.30% +486.12% |
| JsonExtractorBench | bench_extract_10k | 1 | 3 | 4.809mb +0.03% | 1.032s -1.14% | ±0.09% -85.81% |
| ParquetExtractorBench | bench_extract_10k | 1 | 3 | 86.461mb +0.00% | 907.132ms +0.45% | ±0.41% -0.77% |
| TextExtractorBench | bench_extract_10k | 1 | 3 | 4.475mb +0.04% | 34.180ms +5.74% | ±3.45% +399.63% |
| XmlExtractorBench | bench_extract_10k | 1 | 3 | 4.452mb +0.03% | 599.800ms +1.01% | ±0.94% +39.14% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1 | 3 | 108.471mb +0.00% | 59.217ms -1.83% | ±0.92% -17.10% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench | bench_load_10k | 1 | 3 | 54.017mb +0.00% | 121.212ms -0.02% | ±2.74% +95.76% |
| JsonLoaderBench | bench_load_10k | 1 | 3 | 76.777mb +0.00% | 108.859ms +1.18% | ±1.01% +16.55% |
| ParquetLoaderBench | bench_load_10k | 1 | 3 | 166.957mb +0.00% | 19.571s -1.19% | ±0.40% -11.13% |
| TextLoaderBench | bench_load_10k | 1 | 3 | 17.060mb +0.02% | 45.841ms +3.87% | ±0.81% -33.71% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench | bench_chunk_10_on_10k | 2 | 3 | 80.246mb +0.00% | 4.428ms +6.39% | ±2.34% +186.63% |
| RowsBench | bench_diff_left_1k_on_10k | 2 | 3 | 97.522mb +0.00% | 183.741ms +2.25% | ±0.93% +141.14% |
| RowsBench | bench_diff_right_1k_on_10k | 2 | 3 | 80.242mb +0.00% | 18.659ms +0.95% | ±1.18% +202.83% |
| RowsBench | bench_drop_1k_on_10k | 2 | 3 | 81.121mb +0.00% | 1.844ms -7.48% | ±3.32% +1.07% |
| RowsBench | bench_drop_right_1k_on_10k | 2 | 3 | 81.121mb +0.00% | 2.023ms +4.69% | ±1.24% -29.28% |
| RowsBench | bench_entries_on_10k | 2 | 3 | 79.282mb +0.00% | 3.960ms +2.68% | ±1.58% +5.58% |
| RowsBench | bench_filter_on_10k | 2 | 3 | 79.811mb +0.00% | 15.915ms +0.42% | ±0.50% -60.44% |
| RowsBench | bench_find_on_10k | 2 | 3 | 79.811mb +0.00% | 16.062ms +0.45% | ±2.71% -20.93% |
| RowsBench | bench_find_one_on_10k | 10 | 3 | 78.502mb +0.00% | 2.000μs -4.75% | ±0.00% -100.00% |
| RowsBench | bench_first_on_10k | 10 | 3 | 78.502mb +0.00% | 0.400μs 0.00% | ±0.00% 0.00% |
| RowsBench | bench_flat_map_on_1k | 2 | 3 | 86.839mb +0.00% | 13.997ms +1.71% | ±1.41% -35.97% |
| RowsBench | bench_map_on_10k | 2 | 3 | 114.187mb +0.00% | 61.473ms +0.30% | ±3.37% +1819.32% |
| RowsBench | bench_merge_1k_on_10k | 2 | 3 | 80.331mb +0.00% | 1.769ms -3.96% | ±1.89% -51.95% |
| RowsBench | bench_partition_by_on_10k | 2 | 3 | 83.621mb +0.00% | 61.032ms -0.58% | ±1.27% +133.30% |
| RowsBench | bench_remove_on_10k | 2 | 3 | 81.383mb +0.00% | 4.220ms -1.04% | ±3.81% +86.08% |
| RowsBench | bench_sort_asc_on_1k | 2 | 3 | 78.783mb +0.00% | 41.172ms -4.03% | ±1.12% +25.75% |
| RowsBench | bench_sort_by_on_1k | 2 | 3 | 78.784mb +0.00% | 45.862ms +3.60% | ±0.92% +2.83% |
| RowsBench | bench_sort_desc_on_1k | 2 | 3 | 78.783mb +0.00% | 43.347ms -4.17% | ±1.23% -59.76% |
| RowsBench | bench_sort_entries_on_1k | 2 | 3 | 80.942mb +0.00% | 8.410ms +3.18% | ±2.06% -11.96% |
| RowsBench | bench_sort_on_1k | 2 | 3 | 78.692mb +0.00% | 32.268ms -1.17% | ±1.97% +69.27% |
| RowsBench | bench_take_1k_on_10k | 10 | 3 | 78.502mb +0.00% | 14.784μs +4.02% | ±3.43% +418.31% |
| RowsBench | bench_take_right_1k_on_10k | 10 | 3 | 78.502mb +0.00% | 15.899μs -5.92% | ±3.83% +0.00% |
| RowsBench | bench_unique_on_1k | 2 | 3 | 97.523mb +0.00% | 186.484ms -0.02% | ±2.75% +277.99% |
| TypeDetectorBench | bench_type_detector | 1 | 3 | 43.772mb +0.00% | 352.302ms +1.31% | ±1.50% +699.65% |
| TypeDetectorBench | bench_type_detector | 1 | 3 | 11.581mb +0.00% | 70.326ms -1.03% | ±0.78% +305.76% |
| NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 98.638mb +0.00% | 436.572ms -0.69% | ±0.42% -43.77% |
| NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 51.468mb +0.00% | 218.927ms -2.08% | ±0.34% +86.34% |
| NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 13.640mb +0.00% | 49.810ms +2.63% | ±0.76% +37.59% |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.x #1350 +/- ##
==========================================
+ Coverage 82.57% 82.59% +0.01%
==========================================
Files 641 641
Lines 17290 17298 +8
==========================================
+ Hits 14278 14288 +10
+ Misses 3012 3010 -2
|
norberttech
commented
Jan 10, 2025
| - src/adapter/etl-adapter-logger/tests/* | ||
| - src/adapter/etl-adapter-json/tests/* | ||
| - src/adapter/etl-adapter-http/tests/* | ||
| - src/adapter/etl-adapter-csv/tests/* |
There was a problem hiding this comment.
tests are excluded because in manny cases we need to pass incorrect arguments to test what will happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
Reference: #1345