Adds a pretty decoder that removes Aeson portion of decoding error #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits the error message produced by `fromValue` into two: the Aeson and Fleece error message combined (the original behavior) and just the Fleece error message (that produced by the schema and the `Decoder` functions). `decodePretty`, as a result, produces a slightly easier to understand error message that is more suitable for displaying to users. Ideally, we would be able to remove the type from the error messages produced by the `Decoder` functions as well, but for now, this isn't changing that since it would alter the current tests' expected results.
qxjit
requested changes
Jan 8, 2024
|
|
||
| decodePretty :: Decoder a -> LBS.ByteString -> Either String a | ||
| decodePretty decoder = | ||
| mapLeft snd . fromValue decoder <=< Aeson.eitherDecode |
There was a problem hiding this comment.
Rather that offer a separate decodePretty function it would be better to make the decode function return a new error type other than String that the caller could then decide how to format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the error message produced by
fromValueinto two: the Aeson and Fleece error message combined (the original behavior) and just the Fleece error message (that produced by the schema and theDecoderfunctions).decodePretty, as a result, produces a slightly easier to understand error message that is more suitable for displaying to users. Ideally, we would be able to remove the type from the error messages produced by theDecoderfunctions as well, but for now, this isn't changing that since it would alter the current tests' expected results.