Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid closing externally created http.Client in NetworkTileProvider #2012

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

JaffaKetchup
Copy link
Member

Fixes #2009

@JaffaKetchup JaffaKetchup requested a review from a team January 14, 2025 18:14
@JaffaKetchup JaffaKetchup changed the title fix: avoid closing externally created http.Client in network tile provider fix: avoid closing externally created http.Client in NetworkTileProvider Jan 14, 2025
Copy link
Contributor

@mootw mootw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JaffaKetchup JaffaKetchup merged commit 48832da into master Jan 14, 2025
7 checks passed
@JaffaKetchup JaffaKetchup deleted the fix-2009 branch January 14, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] NetworkTileProvider and CancellableNetworkTileProvider close externally created clients
2 participants