fix: use Client instead of BaseClient in network tile/image provider
#2011
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaffaKetchup
changed the title
Client instead of BaseClient in network tile/image provider (#2010)
JaffaKetchup
changed the title
Client instead of BaseClient in network tile/image provider (#2010)Client instead of BaseClient in network tile/image provider
|
Hi @slightfoot, we plan to release the next major version soon :) Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2010
Issue
NetworkTileProviderandMapNetworkImageProvidercannot be used with implementations of the httpClientlibrary.Resolution
Switch out incorrect
BaseClientusage withClient.References
Notes
This fix uses the interface class and not the mixin implementation class that is used at the moment.
This change is backwards compatible and will not affect current usage of these classes as BaseClient implements Client interface.
@JaffaKetchup I am working on a project that would need this change. I'd be most greatful if we can get this out in a release. Thanks!